Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746795 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchollingsworth@xxxxxxxxx --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> 2011-10-17 18:19:16 EDT --- If you need a sponsor, please add "FE_NEEDSPONSOR" to the "Blocks" section of this bug. In the meantime, here's an informal review: > BuildRequires: cmake, gcc-c++ It is not necessary to BuildRequire gcc-c++; it's part of the standard build environment: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires > -DCMAKE_INSTALL_PREFIX=%{_prefix} -DLIB_INSTALL_DIR=%{_lib} These two arguments to CMake are defined by the %cmake macro and aren't needed. To see what %cmake expands to, look at its definition in /etc/rpm/macros.cmake In fact, it appears the second one is causing x86_64 builds to fail: http://koji.fedoraproject.org/koji/getfile?taskID=3438052&name=build.log http://koji.fedoraproject.org/koji/taskinfo?taskID=3438051 > %post > %postun No need to include these if they're empty. > %changelog Please put a simple changelog entry here. Finally, please break lines around 40 characters (the description is ridiculously long) and add some whitespace between sections so your spec file is easier to read. You should also provide rpmlint output in your review: http://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint http://fedoraproject.org/wiki/Packaging:ReviewGuidelines Good luck. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review