Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745510 --- Comment #6 from Rafael Aquini <aquini@xxxxxxxxx> 2011-10-17 12:58:30 EDT --- Frederico, In spite of this is being an informal review, I ask you to consider some of the following observations, please. * As I could not find your Fedora Account, I don't know if this is your first RPM package submission or not. If this is you first submission, take a closer look at: - http://fedoraproject.org/wiki/PackageMaintainers/Join * You should write entries to the %changelog section, with review stuff to keep track of modifications made to the package, as reviews usually impose some spec/srpm changing. In order to improve your changelogs, take a look at: - http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs * The release number is how the maintainer marks build revisions, and it should start from 1. Whenever a minor change (spec file changed, patch added/removed) occurs, or a package is rebuilt to use newer headers or libraries, the release number should be incremented; - http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag (In reply to comment #5) > The commit g69eb727 is not present in the repository since it's actually the > spec modification. When the package will be accepted the hash will appear > upstream. This in not the correct way to proceed. Code shipped as rpm source must _always_ match upstream. It really doesn't matter if your code is either a downloaded tarball, or a tarball built based on a SCM checkout. Prior to have this work aproved, you should fix this item, as this is a real blocker. In order to dismiss any shadow of doubt, please, check the 10th mandatory item from http://fedoraproject.org/wiki/Packaging:ReviewGuidelines "MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this" Cheers! --aquini -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review