Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746368 --- Comment #1 from Paul Wouters <paul@xxxxxxxxxxxxx> 2011-10-16 17:31:52 EDT --- two issues found. Please fix missing build dependancy: openssl-devel It installs a file /usr/share/doc/COPYING. This is very generic and should not be installed there, or use a specific name like COPYING-dnssec-nodes. Note an F-14 branch cannot be requested unless dnssec-tools-libs there is bumped from 1.10 to 1.11. MUST items: * OK: Complies to package nameing guidlines * OK: matches base package * OK: Meets package guidelines * OK: Valid license BSD matches source code * OK: Written in Americanized engish as required (sadly) * OK: COPYING packaged in %doc * OK: spec file legible * OK: source matches upstream source * OK: package compiles and builds on main architecture * FAIL: buildrequires missing openssl-devel and desktop-file-utils * OK: no bad locale handling * OK: no libraries, no ldconfig calls in post/postun * OK: not relocatable * OK: does not create or need to own directories * OK: no duplicate files listed * OK: Does not bundle other libraries * OK: macro use consistent * OK: package contains code or permissable content * OK: no large document files * OK: no header files in base package * OK: no static libraries * OK: no .so files in base package * OK: no devel package dependancy issues * OK: package does not contain .la files * OK: gui dnssec-nodes.desktop properly installed with desktop-file-install * FAIL: Packages must not own files or directories already owned by other packages. Though this is not true, the file /usr/share/doc/COPYING is too generic and could cause issues with other packages * OK: filenames are valid UTF-8 SHOULD items: * Packager should bug upstream about license file (packager IS upstreams, go twist their rubber arm) * No translation of description/summary in other languages available * Reviewer tested build in mock and found missing BuildRequires * no scriplets present * no subpackages present * no pkgconfig present * no outside file dependancies * WARN: missing man page for dnssec-nodes Encourage upstream to write one :) Personal: I would use "install" or "cp" over %{_cp} For your upstream hat: for upstream: * Add COPYING file (maintainer copied it in) * make clean does not remove dnssec-nodes * add man page for dnssec-nodes * there is a bogus softlink stest -> /home/hardaker/tmp/h/somewhere rpmlint: dnssec-nodes.src: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava dnssec-nodes.x86_64: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava dnssec-nodes.x86_64: W: no-manual-page-for-binary dnssec-nodes 3 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review