Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: warzone2100 - Innovative 3D real-time strategy https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221065 faucamp@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From faucamp@xxxxxxxxxx 2007-01-22 01:43 EST ------- Thanks for requesting the tests. Now at least we are sure. :-) MUST items: * rpmlint output: W: warzone2100-data no-documentation --- can be ignored, silent otherwise * package is named well * spec file is named well * package meets Packaging Guidelines * package license is GPL, COPYING file included * License field in spec file matches actual license * license file is included in %doc * spec file is written in American English and legible * package source md5sum matches upstream source: 56e83a64d5b7aa60ced3d7ac7281bb42 warzone2100-2.0.5.tar.bz2 * package builds successfully on fc6/i386, PPC (PPC builds not done by me, but tested throughout review) * BuildRequires are good * package handles locales properly (no locales) * package has no need for %post and %postun sections * package is not relocatable * package owns directories it creates * no duplicate entries in %files * file permissions are good * proper %clean section * spec file macros are used consistently * main package contains code, -data subpackage contains permissable content * no -doc, -devel subpackages necessary * contents in %doc not required for runtime functionality of application * .desktop file present and properly handled SHOULD items: * package builds in mock (fc6/i386) * package functions properly on i386 and PPC - ExludeArch x86_64 is present until this issue is can be resolved (see comments #16 and #20 for resolution) * subpackages require the base package using a fully versioned dependency Everything has been met. ------------------------- This package is APPROVED. ------------------------- After importing this package, please file a bug against it detailing the 64-bit pointer issues as discussed in comment #18. The bug number should then also be placed in a comment, next to the corresponding ExcludeArch line in the spec file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review