Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737550 --- Comment #3 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2011-10-14 08:30:10 EDT --- (In reply to comment #2) > - Remove unused definitions (ruby_sitelib, ruby_sitearch) Done. > - You don't need to specify the BuildRoot, see [1] Done. > - Be a little more verbose in the description section (you can for example add > the line from README.mkd - "Minimalist way to build and publish gems using > Rake. Also build tarballs."). Done > - Consider introducing doc subpackage and moving %doc > %{gemdir}/doc/%{gemname}-%{version} into it. Thanks for the suggestion. I've put that separation back into the spec. > - Next time, consider using gem2rpm, it saves a lot of work when packaging > rubygems. This spec file -was- generated with gem2rpm. > [1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Here are the updated files: SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-mg.spec SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-mg-0.0.8-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review