Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745993 --- Comment #2 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2011-10-14 06:36:01 EDT --- - You should run tests/specs it upstream has them. Download them from upstream (https://github.com/josh/useragent), make another source of them and use them. You can look at [1] for an example of how this can be done. - It is not necessary to include license both in the main package and in the doc subpackage, since the doc subpackage Requires the main one (and thus can only be present if the main one is). I would recommend leaving the LICENSE file just in the main package. [1] http://bkabrda.fedorapeople.org/bson_ext/rubygem-bson_ext.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review