Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720857 --- Comment #15 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2011-10-11 18:08:22 EDT --- Hi John. Nice work on the package, a few minor things and we'll go for the review. Had a look at the package, here are some remarks and things that need to be fixed: - datalog IS the right name (Lua is an implementation detail, it is not a Lua module) - You need to create a -devel sub-package to package header and .so (no suffix) files (.so.0.0.0 stays in the main package). - write the full sourceforge URL (not sf.net) - remove the Packager field - Can you relax the build requirement? If there was a 5.1.5 it wouldn't build anymore, but that version would only have minor changes. If you feel that it is likely to need some work keep it as is. - define the luapkgdir at the top of the file - remove the newline between %description and the text -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review