Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Miloslav Trmač <mitr@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(tmraz@xxxxxxxxxx) --- Comment #1 from Miloslav Trmač <mitr@xxxxxxxxxx> 2011-10-10 09:46:36 EDT --- rpmlint: > libpwquality.src: W: spelling-error %description -l en_US cracklib -> crack lib, crack-lib, crackling > libpwquality-devel.x86_64: W: spelling-error %description -l en_US pwquality -> quality > libpwquality.x86_64: W: spelling-error %description -l en_US cracklib -> crack lib, crack-lib, crackling false positives > libpwquality-devel.x86_64: W: no-documentation oh well... upstream issue > libpwquality.x86_64: W: no-manual-page-for-binary pwscore > libpwquality.x86_64: W: no-manual-page-for-binary pwmake upstream issue, however would be good to fix soonish Needs fixing: * Doesn't build in koji At least missing BuildRequires: pam-devel * Licensing problems/uncertainty: * License field says (BSD and GPLv2+) * Licensing guidelines require using "or" for dual licensing * Source files allow BSD or referenced GPL (note: not GPLv2, not GPL+!) * COPYING contains the same reference to GPL without v2/+, but includes text of GPLv2 * Source URL incorrect * Per "File and Directory Ownership" (gdm example), there should be > Requires: pam for {/etc,%_libdir}/security instead of relying on the automatic libpam dependency. Not sure: * I'm not quite happy about > ln -sf ../../%{_lib}/libpwquality.so.*.* libpwquality.so this only works for some values of %{_libdir}. Using an absolute symlink would be more general - OTOH this is not really a concern for Fedora * If you plan to maintain ChangeLog, please include it in %doc Notes: * Unnecessary > Requires(postun): /sbin/ldconfig - the -p interpreter is added automatically * BuildRoot: is unnecessary * %global is preferred over %define * Consider using (make install ... INSTALL='install -p') to preserve timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review