Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: IceWM - Lightweight Window Manager. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521 ------- Additional Comments From pertusus@xxxxxxx 2007-01-21 08:35 EST ------- * In %files the second line is redundant: %attr(0755,root,root) %{_bindir}/icewm-xdg-menu* %{_bindir}/icewm-xdg-menu* * Instead of using your script, I think it would be better to modify icewm-xdg-menu. There is already the option --entire-menu. I have taken a function findIcon from fluxbox-xdg-menu and added --with-icons and --theme options. I think that with that patch icewm-xdg-menu --with-icons --entire-menu does the same than your script, but is faster... * The license for icewm-xdg-menu is missing. I will contact upstream to submit my patch and ask him. * there is no need to split an automenu subpackage for an additional script. The changelog entry is a bit strange since it states sub-package: icewm-xdg-menu although the subpackage name is icewm-automenu. * there is a missing dot at the end of the -gnome subpackage %description -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review