Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554464 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #18 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-10-09 12:14:15 EDT --- (In reply to comment #17) > (In reply to comment #16) > > - Disabling the internal dependency generator is not needed, when using: > > > > https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Arch-specific_extensions_to_scripting_languages > > OK, I fixed that (I used the first option). OK > > - For a failing test suite you could append "| :" so at least anything else is > > checked for now. (Maybe it will completely work, when you also add the > > dependencies) > > As it turned out, this is a good thing because it uncovered new failed unit > tests. > I noted how many tests are failing and added a link to the upstream bug report. Thanks. Some are failing because of a missing "testdata5m.txt", when generating the tar ball upstream seems to not include that here. Some others seem to cause failures in pydot: File "/usr/lib/python2.7/site-packages/pydot.py", line 682, in <lambda> self.__setattr__('get_'+attr, lambda a=attr : self.__get_attribute__(a)) File "/usr/lib/python2.7/site-packages/pydot.py", line 594, in __get_attribute__ defaults = self.get_parent_graph().get_node( default_node_name ) This also makes it impossible to run the tutorials from: http://packages.python.org/pebl/tutorial.html Maybe it would be best to file a bug against pydot... > Links to the updated files: > Spec URL: http://tadej.fedorapeople.org/python-pebl.spec > SRPM URL: http://tadej.fedorapeople.org/python-pebl-1.0.2-6.fc15.src.rpm > > I also did a scratch build of the package in koji and the results are here: > http://koji.fedoraproject.org/koji/taskinfo?taskID=3416390 Thanks. ______________________________________________________ The package/spec looks fine, but I'd not import this, untill the tutorials are working... Filed as a bug against pydot with a patch (see depends on bug). ______________________________________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review