Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719103 --- Comment #20 from Peter Robinson <pbrobinson@xxxxxxxxx> 2011-10-09 11:34:45 EDT --- A few bits need fixing - rpmlint output rpmlint mex-0.2.0-1.fc16.src.rpm mex-0.2.0-1.fc17.x86_64.rpm mex.spec mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/40mex-recommended.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/20mex-upnp.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/20mex-gnome-dvb.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/40mex-queue.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/00mex-search.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/mex-thumbnailer ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/20mex-tracker.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex-webremote ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/mex/plugins/50mex-dbusinput.so ['/usr/lib64'] mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/media-explorer ['/usr/lib64'] mex.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmex-0.2.so mex.x86_64: W: no-manual-page-for-binary mex-webremote mex.x86_64: W: no-manual-page-for-binary media-explorer 2 packages and 1 specfiles checked; 10 errors, 3 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 66eda375fdede3e0df652de7024aeff0 mex-0.2.0.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + Package perserves timestamps on install Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' - libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files + packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin Package should have man files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review