Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |loganjerry@xxxxxxxxx --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> 2011-10-07 18:02:37 EDT --- Since I started the original review, I guess I should see it through to the bitter end. :-) I see a couple of problems in the build I just did. First, configure says: checking for SQLFetch in -lodbc... no which is wrong. We do have SQLFetch in that library. Checking further, I see this in config.log: configure:15378: gcc -o conftest -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic conftest.c -lodbc ODBC \(libodbc\) library not found >&5 gcc: error: ODBC: No such file or directory gcc: error: \(libodbc\): No such file or directory gcc: error: library: No such file or directory gcc: error: not: No such file or directory gcc: error: found: No such file or directory That's because this line in configure.in has one too many commas: AC_CHECK_LIB([odbc], [SQLFetch], ODBCFOUND=1,,[ODBC \(libodbc\) library not found]) Change the double-comma in front of the error message to a single comma, and all is well. Second, saga-2.0.7-g2clib.patch is wrong, in two ways. It is wrong, because it assumes that libgrib2c.a is available in /usr/lib64. On 32-bit systems, it isn't; it is in /usr/lib. Second, it is wrong because the -L flag tells the linker *a directory* in which to look for libraries, not the name of an actual library. The end result is that the contents of libgrib2c.a are not in libio_grid_grib2.so. Using readelf, you can see that libio_grid_grib2.so contains references to g2_free and g2_getfld, both of which are marked undefined. To fix both problems, change the patch to add "-lgrib2c" to AM_LDFLAGS instead of the current "-L...". The linker will use a static library to satisfy a link request such as this when it cannot find a shared library. Things look pretty good in general, otherwise. If you can get me a package that fixes those two problems, I'll do a full review on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review