Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588428 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@xxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-10-07 08:19:20 EDT --- This package is needed for rubygem-webmock as well. Taking the review * package depends on rubygem-idn, review for that in progress * package builds fine in mock w/ rubygem-idn manually installed * rpmlint looks good * Package matches upstream source's md5sum $ md5sum rpmbuild/SOURCES/addressable-2.2.6.gem Downloads/addressable-2.2.6.gem 3eec7c544b664f28023ff5d7fb0116ef rpmbuild/SOURCES/addressable-2.2.6.gem 3eec7c544b664f28023ff5d7fb0116ef Downloads/addressable-2.2.6.gem * Can you remove references to ruby_sitearch as this is a noarch gem package * As mentioned before could you replace the "%doc %{geminstdir}/[A-Z]*" with the doc files explicitly listed, just to prevent unintentional mistakes in the future (if non-doc files are added to the upstream project that match this) * since %geminstdir is being marked as a %dir in the files section, does the Rakefile need to be marked w/ %exclude? (why exclude the Rakefile but then include the lib subdir?) * The README file is currently listed twice, first as a doc in the main package (pulled in as part of the aforementioned wildcard expression) and then again in the docs subpackage, either place is acceptable but it should only appear once http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles Other than that the package looks good. Thanks for the submissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review