[Bug 736861] Review Request: hgview - A fast Mercurial log navigator written in pyqt4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736861

--- Comment #6 from Volker Fröhlich <volker27@xxxxxx> 2011-10-07 06:40:36 EDT ---
There is some typo or grammar mistake in the first line of the description:

"hgview is a simple tool aiming at visually navigate in a Mercurial repository"
-- "navigating" maybe?

You should only set python_sitelib for systems that don't define it. Please see
http://fedoraproject.org/wiki/Packaging:Python#Macros

The rm in the install section is not necessary. 

Qscintilla-python already requires PyQt4, so you don't have to state that
explicitly.

README: "The Text interface depends on urwid, pygments and pyinotify" -- Did
you leave that out on purpose?

If you find the time, please correct "intarfece" in the README file and tell
upstream. You probably shouldn't ship that file at all, as it gives
instructions on how to run it from a check-out, which is not what the package
is about.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]