Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728088 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmorsi@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-10-06 20:04:13 EDT --- Taking this one * rpmlint looks good * koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3407485 * The license refers to ASL and MIT but I was only able to find ASL in the project, which components are licensed under MIT? The files you pointed out are all licensed under the ASL http://www.apache.org/licenses/LICENSE-2.0 * Also the NOTICE file states that "This software contains code derived from the Net::XMPP for Ruby project by Yuki Mitsui (http://netxmpp-ruby.jabberstudio.org/)" This exact url does not seem to be accessible but I found the project's website which indicates that it is licensed under the LGPL: http://jabberstudio.org/projects/netxmpp/project/view.php I'm not sure what they mean their code is "derived" from net-xmpp, but it might be good to clarify (I believe licensing the project under ASL v2 AND LGPL would be acceptable) * rm -rf %{buildroot} is no longer needed at the beginning of the %install section * since you are packaging this gem for non-gem use, that non-gem subpackage needs to own the ruby_sitelib symlinks according to these guidelines: "- All the toplevel library files of the Gem must be symlinked into ruby_sitelib. - The subpackage must own these symbolic links." Other than these, package looks good -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review