Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713990 --- Comment #5 from Dan Callaghan <dcallagh@xxxxxxxxxx> 2011-10-05 19:50:28 EDT --- Thanks for taking this review on, Andy. (In reply to comment #3) > A few things: > > 1) Please fix the FSF address in these files (the correct address is here: > http://www.fsf.org/about/contact/ ): > > [...] > > You should also send the change to the upstream maintainers of this project. It looks [1] like the current recommendation is just to put an URL to the GPL rather than the FSF's mailing address, which I think makes much more sense. I've added a patch to do that, and filed it upstream [2]. > 2) Several parts of this spec are no longer needed in recent Fedora releases, > and should be removed: > > a) "%defattr(-,root,root,-)" in the %files section > b) the %clean section > c) "rm -rf $RPM_BUILD_ROOT" in the %install section Done. > 3) This package does not function without python-fastimport, so it should have > a Requires line for this. Oops, probably the most important part of the spec file. Not sure how I missed that! Fixed. (In reply to comment #4) > Another note on this: the latest version of bzr-fastimport is 0.11.0. 0.10.0 > has at least one issue with current bzr due to the relocation of the > KnitPackRepository module. Version bumped. Updated spec and SRPM are here: http://fedorapeople.org/~dcallagh/bzr-fastimport/bzr-fastimport.spec http://repos.fedorapeople.org/repos/dcallagh/bzr-fastimport/fedora-15/SRPMS/bzr-fastimport-0.11.0-1.fc15.src.rpm [1] http://www.gnu.org/licenses/gpl-howto.html [2] https://bugs.launchpad.net/bzr-fastimport/+bug/868789 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review