Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739398 --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> 2011-10-05 17:29:01 EDT --- Builds in mock rawhide/x86_64. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result openblas.src:11: W: macro-in-comment %{version} openblas.src:11: W: macro-in-comment %{alpha} openblas.src:112: E: hardcoded-library-path in %{buildroot}/usr/lib/libopen* openblas.src: W: invalid-url Source0: xianyi-OpenBLAS-v0.1alpha2.4-0-gfe7a932.tar.gz openblas-static.x86_64: W: no-documentation openblas-devel.x86_64: W: no-documentation openblas-threads.x86_64: W: spelling-error Summary(en_US) pthreads -> threads, p threads, packthread openblas-threads.x86_64: W: no-soname /usr/lib64/libopenblasp-r0.1alpha2.4.so openblas-threads.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenblasp-r0.1alpha2.4.so exit@GLIBC_2.2.5 openblas-threads.x86_64: W: no-documentation openblas-openmp.x86_64: W: no-soname /usr/lib64/libopenblaso-r0.1alpha2.4.so openblas-openmp.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenblaso-r0.1alpha2.4.so exit@GLIBC_2.2.5 openblas-openmp.x86_64: W: no-documentation openblas.x86_64: W: no-soname /usr/lib64/libopenblas-r0.1alpha2.4.so openblas.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenblas-r0.1alpha2.4.so exit@GLIBC_2.2.5 openblas.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 1 errors, 15 warnings. The gcc command which the library is linked with lacks -Wl,-soname=, hence the no-soname warning from rpmlint. I think this must be fixed. Fixing this properly might also require modifying the %files lists apart from patching the Makefiles. $ md5sum v0.1alpha2.4 xianyi-OpenBLAS-v0.1alpha2.4-0-gfe7a932.tar.gz c23bc85bc536b175533b862e964b4fe1 v0.1alpha2.4 c23bc85bc536b175533b862e964b4fe1 xianyi-OpenBLAS-v0.1alpha2.4-0-gfe7a932.tar.gz The changes from GotoBLAS2 are mainly added support for the Chinese Loongson CPU and some superficial changes like minor build system tweaks, renamed files, new name and added copyright/license texts. Bundles lapack-3.1.1 sources -> investigate unbundling, if sources are necessary to build, contact lapack maintainer to add a -source subpackage and BuildRequire it. Bundles some files from lapack-3.0 sources, at least lapack/getri/*.f. Bundles http://www.netlib.org/blas/blast-forum/cblas.tgz:CBLAS/testing directory as ctest/ and (modified) test/. Also cblas.h is basically the same, only reformatted and with parameter names changed. Bundles a modified http://www.netlib.org/blas/blas.tgz:BLAS directory as reference/. I guess the above are GotoBLAS2's legacy. make -C serial TARGET=CORE2 ... Minimum requirements for Fedora are still Pentium Pro or newer. Will this run on a Pentium Pro? # Get rid of rpaths for lib in %{buildroot}%{_libdir}/libopenblas{,o,p}-*.so; do execstack -c $lib done The comment seems wrong. Also, is that the only way to remove executable stack? rm -rf %{buildroot} in %install and the %clean section are only necessary for EPEL. There are no docs included in %files. I'd suggest at least these: Changelog.txt GotoBLAS*.txt LICENSE <- especially important (MUST be included) README -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review