Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710648 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ktdreyer@xxxxxxxxxxxx --- Comment #3 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> 2011-10-04 20:23:49 EDT --- OK - MUST: rpmlint must be run on source and binaries $ rpmlint /var/lib/mock/fedora-16-i386/result/clusterPy-0.9.9-2.fc16.noarch.rpm clusterPy.noarch: W: spelling-error Summary(en_US) Analytical -> Analytically, Analytic, Catalytic clusterPy.noarch: W: spelling-error Summary(en_US) regionalization -> rationalization, marginalization, denationalization clusterPy.noarch: W: spelling-error %description -l en_US Analytical -> Analytically, Analytic, Catalytic clusterPy.noarch: W: spelling-error %description -l en_US regionalization -> rationalization, marginalization, denationalization clusterPy.noarch: W: spelling-error %description -l en_US Arisel -> Ariel, Arise, Arises clusterPy.noarch: W: spelling-error %description -l en_US geoSOM -> geom 1 packages and 0 specfiles checked; 0 errors, 6 warnings. $ rpmlint /var/lib/mock/fedora-16-i386/result/clusterPy-0.9.9-2.fc16.src.rpm clusterPy.src: W: spelling-error Summary(en_US) Analytical -> Analytically, Analytic, Catalytic clusterPy.src: W: spelling-error Summary(en_US) regionalization -> rationalization, marginalization, denationalization clusterPy.src: W: spelling-error %description -l en_US Analytical -> Analytically, Analytic, Catalytic clusterPy.src: W: spelling-error %description -l en_US regionalization -> rationalization, marginalization, denationalization clusterPy.src: W: spelling-error %description -l en_US Arisel -> Ariel, Arise, Arises clusterPy.src: W: spelling-error %description -l en_US geoSOM -> geom 1 packages and 0 specfiles checked; 0 errors, 6 warnings. $ rpmlint clusterPy.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. False positives on spelling. No problems here. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 392beb2c03b14f710055c33547ec7ced OK - MUST: successfully compiles and builds into binary rpms on F15/16. N/A - MUST: no ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. N/A - MUST: handles locales properly with %find_lang N/A - MUST: calls ldconfig in %post and %postun OK - MUST: does not bundle copies of system libraries. N/A - MUST: not designed to be relocatable OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: permissions on files are set properly OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application N/A - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: If a package contains library files with a suffix, then library files that end in .so must go in a -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. N/A - MUST: Packages containing GUI applications must include a %{name}.desktop file OK - MUST: package does not own files or directories already owned by other packages. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. OK - SHOULD: functions as described. OK - SHOULD: Scriptlets are sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Other items: OK - latest stable version OK - SourceURL valid Issues: Personal nit: no need for "index.html" in the URL. It's sort of like extraneous uses of "cat" in shell scripts :) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review