Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741129 --- Comment #2 from Matthieu Saulnier <casper.le.fantom@xxxxxxxxx> 2011-10-04 09:48:26 EDT --- (In reply to comment #1) Hello > Just a few comments: > - your package provides a single JAR file, you *don't* have to create a > dedicated directory for it in %{_javadir}: > http://fedoraproject.org/wiki/Packaging:Java#Installation_directory > By the way, you'll fix so the %{_javadir}/%{name}/ directory which is not owned > by your package. Done > > - you should probably name your icon « %{name}.svg » instead of « stenago.svg > », this may be more coherent. Done > > - the Ant build file provides a Javadoc target (ant doc); you *must* build it > and provide it in a separate package: > http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Done > > - did you try to run the executable script generated by %jpackage_script? I > really don't think so, because the Main class you provided to %jpackage_script > (com.sun.msv.driver.textui.Driver) has *nothing* to do with openstengo. It > *can't* work! > You can get the Main class by opening the generated jar file and read the > MANIFEST.MF file. By the way, the generic script openstengo.sh file sets memory > options that can be good to reuse in %jpackage_script (second argument of the > macro). Done > > - about these lines: > #delete file for Windows : > rm -f %{buildroot}/openstego.bat > I suppose you try to delete the BAT file in the sources. The %{buildroot} is > *not* the source tree. This command does nothing (see silent -f option). If you > want to delete a file in the sources, you'd better do it in %prep, which is run > in the source tree, as for the %build/%install targets. By the way, this step > is useless since this script has no impact in the build, you should ignore it. Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review