Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743007 --- Comment #4 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2011-10-04 03:26:41 EDT --- * %{geminstdir}/README.md should be marked as %doc. * The way you run tests doesn't actually run them (0 tests, 0 assertions, 0 failures, 0 errors). When you run them this way: 'testrb -Ilib ./test/*_test.rb', you can discover, that you need to include BR: rubygem(metaclass) and BR: rubygem(builder) (the second one to satisfy the require 'blankslate' in snapshot_test.rb). Please clarify these BRs. * Consider including license file from the upstream in the package (maybe as a separate source). * Could you explain if there currently is a particular reason for R: rubygem-metaclass < 0.1? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review