Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tilda - a quake like drop down terminal for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222372 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2007-01-20 08:33 EST ------- Review for dd8afaafb2657d6cabc43b93a7d408c8 tilda-0.9.4-3.src.rpm FIX - rpmlint not silent on the SRPM: W: tilda macro-in-%changelog doc fix this by adding a second '%' to %doc: %%doc OK - package and spec named according to the package naming guidelines OK - package meets packaging guidelines OK - license is open-source compatible (GPLv2) OK - license field in spec matches actual license OK - COPYING included in source and correctly installed in %doc OK - spec is in American English OK - spec is legible OK - source in srpm matches upstream by md5 773d47e3985f7e778b662a38b053c1df OK - package compiles and build into binaries on Core 6 i386 OK - no known ExcludeArchs FIX - BuildRequires not correct: gettext is not required. FIX - ./configure checks for libXt (see config.log ~182), so you should BuildRequire libXT-devel Note - two redundant BRs that could be removed: glib2-devel is required by pango-devel, gtk2-devel is pulled in by vte-devel OK - no locales to worry about OK - no shared libs to worry about OK - package is not relocatable OK - package owns all directories it creates (it doesn't create any) OK - no duplicates in %files NOTE - I guess tilda.png should also be installed to %{_datadir}/icons/hicolor/48x48/apps/ for it is size specific OK - file permissions and %defattr correct OK - valid clean section OK - macro usage consistent OK - code, not content OK - no large docs OK - docs don't affect runtime NOTE - You can remove the NEWS from %doc as long as it only tells you to look at the README OK - no header files, static libs or *.pc files OK - no libtool archives OK - desktop file included and correctly installed with desktop-file-install FIX - add '--remove-category="Application"' to desktop-file-install as "Application" no longer is a valid category according to http://standards.freedesktop.org/menu-spec/latest/apa.html NOTE - you could also add '--copy-name-to-generic-name' so we get a generic name NOTE - consider adding a comment to the desktop file. As a quick fix use something like 'echo "Comment=A quake like terminal for GNOME" >> tilda.desktop' during %prep OK - package doesn't own directories already owned by other files OK - package builds in mock (devel) OK - basically package works as described but there is no drop down or roll up. Also I see a critical gtk error (" Gtk-CRITICAL **: gtk_window_resize: assertion `height > 0' failed "). NEEDSWORK Please fix at least the "FIX"-issues, before I can approve the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review