Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742189 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-10-03 11:27:17 EDT --- I have few suggestions: * Please check duplicated "Requires: rubygem(addressable)" * Please execute test suite if available upstream. * I would suggest to move following files into -doc subpackage: %{geminstdir}/Gemfile %{geminstdir}/Rakefile %doc %{geminstdir}/minitest %doc %{geminstdir}/test %doc %{geminstdir}/spec %doc %{geminstdir}/%{gemname}.gemspec %doc %{geminstdir}/CHANGELOG.md %doc %{geminstdir}/Guardfile -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review