[Bug 652971] Review Request: code-editor - A text/code editor based on Qt Creator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652971

--- Comment #38 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-09-30 16:44:44 EDT ---
This has nothing to do with rpaths.

Imagine the following scenario:

1) A future separate package in the Fedora package collection, give it the lame
name "liblanguageutils" although it could have a different name. It includes a
system-wide library libLanguageUtils.so.1 and therefore "Provides:
libLanguageUtils.so.1" automatically.

2) A future separate package in the Fedora package collection, name it "foo",
which builds with liblanguageutils-devel and therefore creates an automatic
dependency "Requires: libLanguageUtils.so.1".

3) Attempting to "yum install foo" might decide to pull in code-editor because
it "Provides: libLanguageUtils.so.1" for its private library outside run-time
linker's search path.

4) Attempting to run the foo program will fail, because the needed shared
library from package "liblanguageutils" is not installed yet.

[Similar scenarios are possible when working with sub-packages. Simple
inter-package dependencies can fail to resolve correctly already if multiple
packages provide the same things but for stuff outside standard system search
paths.]


> Do I need to include a:
> 
> rm -f %{buildroot}%{_libdir}/code-editor/lib*.so.1

No, of course not! That would remove the plugin library and might break the
program, because it could not no longer dlopen the library at run-time. :)

You can find documentation about filtering automatic Provides/Requires here:
http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Remember, however, that currently there is no such conflict with any other
package. No damage is done yet. It's just an increased risk to create a sudden
problem some time in the future.

The guidelines say:

| MUST: Packages must not provide RPM dependency information when that
| information is not global in nature, or are otherwise handled (e.g. through
| a virtual provides system). e.g. a plugin package containing a binary shared
| library must not "provide" that library unless it is accessible through the
| system library paths.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]