Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714511 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-09-30 08:10:48 EDT --- Source file is original. Ok. TODO: Remove the `a full range of features for ' substring from summary. This does not come from upstream and I'm not sure this is or will be true forever (despite your additional patches that should be reported to RT). License verified from lib/Net/Google/PicasaWeb.pm and LICENSE. Ok. URL and Source URL Ok. Patches reviewed. Ok. TODO: Submit the patches to upstream. TODO: Remove the BuildRoot definition and cleaning (rm -rf $RPM_BUILD_ROOT) as this default in all Fedora branches. No XS code, noarch BuildArch is Ok. FIX: Remove `BuildRequires: perl(Test::Mock::LWP)'. The Test::Mock::LWP dependency has been removed from code (Changes:26). TODO: Ask upstream to fix Makefile.PL/META.yml. FIX: BuildRequire perl(Carp) (lib/Net/Google/PicasaWeb/Media.pm:11, http://search.cpan.org/dist/Carp/). FIX: BuildRequier perl(HTTP::Request::Common) (lib/Net/Google/PicasaWeb.pm:10, http://search.cpan.org/~gaas/HTTP-Message/) FIX: BuildRequire perl(HTTP::Message) and perl(HTTP::Request) introduced by your patches. TODO: Move the `%{?!_with_network_tests: rm t/offline.t t/online.t}' adjustment from %check phase to %prep phase as it modifies sources. TODO: Use standardized %bcond_with and %with macros instead of your %_with_network_tests (http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds). TODO: Sort BuildRequires and %doc files lexicographically to ease future maintenance. TODO: Omit `-b' %patch option, then you do not need to remove the back-up files produced by patch. TODO: Remove %defattr macro from %files section as it is default in all Fedora branches. TODO: Rename %_bindir scripts (and corresponding manual pages) and package them. Ask upstream for the same change. $ rpmlint perl-Net-Google-PicasaWeb.spec ../SRPMS/perl-Net-Google-PicasaWeb-0.11-2.fc17.src.rpm ../RPMS/noarch/perl-Net-Google-PicasaWeb-0.11-2.fc17.noarch.rpm perl-Net-Google-PicasaWeb.spec:47: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 47) perl-Net-Google-PicasaWeb.src:47: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 47) perl-Net-Google-PicasaWeb.noarch: E: incorrect-fsf-address /usr/share/doc/perl-Net-Google-PicasaWeb-0.11/LICENSE 2 packages and 1 specfiles checked; 1 errors, 2 warnings. TODO: Unify white spaces in spec file (you can use expand(1)). TODO: Report out-dated FSF address to upstream. rpmlint output is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-Google-PicasaWeb-0.11-2.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Sep 30 13:55 /usr/share/doc/perl-Net-Google-PicasaWeb-0.11 -rw-r--r-- 1 root root 82 May 30 16:35 /usr/share/doc/perl-Net-Google-PicasaWeb-0.11/AUTHORS -rw-r--r-- 1 root root 4565 May 30 16:35 /usr/share/doc/perl-Net-Google-PicasaWeb-0.11/Changes -rw-r--r-- 1 root root 18291 May 30 16:35 /usr/share/doc/perl-Net-Google-PicasaWeb-0.11/LICENSE -rw-r--r-- 1 root root 313 May 30 16:35 /usr/share/doc/perl-Net-Google-PicasaWeb-0.11/README -rw-r--r-- 1 root root 5946 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb.3pm.gz -rw-r--r-- 1 root root 2756 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::Album.3pm.gz -rw-r--r-- 1 root root 2692 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::Base.3pm.gz -rw-r--r-- 1 root root 2322 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::Comment.3pm.gz -rw-r--r-- 1 root root 2455 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::Feed.3pm.gz -rw-r--r-- 1 root root 3287 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::Media.3pm.gz -rw-r--r-- 1 root root 2646 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::MediaEntry.3pm.gz -rw-r--r-- 1 root root 2075 Sep 30 13:55 /usr/share/man/man3/Net::Google::PicasaWeb::MediaFeed.3pm.gz drwxr-xr-x 2 root root 0 Sep 30 13:55 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 Sep 30 13:55 /usr/share/perl5/vendor_perl/Net/Google drwxr-xr-x 2 root root 0 Sep 30 13:55 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb -rw-r--r-- 1 root root 22829 Sep 30 13:55 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb.pm -rw-r--r-- 1 root root 4050 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/Album.pm -rw-r--r-- 1 root root 2480 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/Base.pm -rw-r--r-- 1 root root 1883 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/Comment.pm -rw-r--r-- 1 root root 3715 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/Feed.pm -rw-r--r-- 1 root root 8008 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/Media.pm -rw-r--r-- 1 root root 3813 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/MediaEntry.pm -rw-r--r-- 1 root root 1424 May 30 16:35 /usr/share/perl5/vendor_perl/Net/Google/PicasaWeb/MediaFeed.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Google-PicasaWeb-0.11-2.fc17.noarch.rpm |sort -k2 |uniq -c 1 perl(Carp) 1 perl(HTTP::Message) 1 perl(HTTP::Request) 1 perl(HTTP::Request::Common) 1 perl(LWP::UserAgent) 1 perl(:MODULE_COMPAT_5.14.1) 1 perl(Moose) 1 perl(Net::Google::AuthSub) 1 perl(Net::Google::PicasaWeb::Album) 1 perl(Net::Google::PicasaWeb::Comment) 1 perl(Net::Google::PicasaWeb::Media) 1 perl(Net::Google::PicasaWeb::MediaEntry) 1 perl(URI) 1 perl(XML::Twig) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Require perl(MooseX::Role::Matcher) explicitly as rpmbuild does not understand Moose `with' now (lib/Net/Google/PicasaWeb/Base.pm:9). $ rpm -q --provides -p ../RPMS/noarch/perl-Net-Google-PicasaWeb-0.11-2.fc17.noarch.rpm |sort -k2 |uniq -c 1 perl(Net::Google::PicasaWeb) = 0.11 1 perl(Net::Google::PicasaWeb::Album) = 0.11 1 perl(Net::Google::PicasaWeb::Base) = 0.11 1 perl(Net::Google::PicasaWeb::Comment) = 0.11 1 perl(Net::Google::PicasaWeb::Feed) = 0.11 1 perl(Net::Google::PicasaWeb::Media) = 0.11 1 perl(Net::Google::PicasaWeb::Media::Content) = 0.11 1 perl(Net::Google::PicasaWeb::MediaEntry) = 0.11 1 perl(Net::Google::PicasaWeb::MediaFeed) = 0.11 1 perl(Net::Google::PicasaWeb::Media::Thumbnail) = 0.11 1 perl(Net::Google::PicasaWeb::Tag) = 0.11 1 perl-Net-Google-PicasaWeb = 0.11-2.fc17 Binary Provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-Google-PicasaWeb-0.11-2.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3391118). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items and provide new package. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review