Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711893 --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-09-27 03:28:57 EDT --- (In reply to comment #4) > - The man page issues are still there, upstream did not get back to me. I'll > have to look at it myself > > - I am not sure how I could run the test suite, as the "build" target is empty, > and we only have something outside of the .gem file after the install phase. I > believe the check phase runs before install? No, the %check is executed after %install section, so you happily execute the test suite there. Also, for newer packages, I suggest to install the gem in %prep section and move it later to the final position in %install section. You can take a look at [1] for example. Also note, that you can use latest rubygem-gem2rpm to generate the spec file which reflects this suggestion. [1] http://pkgs.fedoraproject.org/gitweb/?p=rubygem-bson.git;a=blob;f=rubygem-bson.spec;h=a39e38d8c6dc91562e0043a559b4a91a091e29ac;hb=HEAD -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review