Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739347 --- Comment #12 from Jiri Hladky <hladky.jiri@xxxxxxxxx> 2011-09-26 18:05:12 EDT --- (In reply to comment #11) Hi, please see my comments bellow: > - Patch0 is missing a comment, still. Please add one in the spec file. Well, I have added following text to he description already in https://bugzilla.redhat.com/show_bug.cgi?id=739347#c4 =================================================================== Patch represents changes planed for the version 1.3: 1)Changed run levels: 0=daemon -1=configuration info -2=write Bytes to stdout without limit >0 write <r> Bytes to file. Units k,m,g,t are supported: 2)Added option to write random bytes to stdout: -f - =================================================================== Not sure if I got it wrong - is there special section for it? Or perhaps you have just overlooked it. Please let me know. > - Please drop the "Apply patches: " comment and the following commented line. Done > - Please drop the commented line in %files. Done > - The "spelling-errors" are false alarms. > - Fix the subsystem stuff. It also false alarm. Please run rpmlint -i to see the detailed explanation: haveged.i686: W: incoherent-subsys /etc/rc.d/init.d/haveged ${prog} ...... It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. Init script is indeed using a variable. > NEEDSWORK > - License is GPLv3+, not GPLv3. Good hint, thanks! > - ... but *please* don't use wildcards for just one or two files. Change > %{_mandir}/man8/* > %{_sbindir}/* > %{_initrddir}/* > to > %{_mandir}/man8/haveged.8* > %{_sbindir}/haveged > %{_initrddir}/haveged > or the same using %{name}, both of which have the same effect as the wildcard > but make the %files section MUCH clearer. Done. Spec URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.spec SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.src.rpm Thanks Jirka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review