Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=740160 --- Comment #3 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> 2011-09-25 08:53:15 EDT --- Hi! Someone else will need to sponsor you, but here's some comments: - You should always upload a SRPM file somewhere when updating the spec file and post a link here. It will make it easier for reviewers. Once you upload one, I'll take a closer look. - You seem to have the subpackage idea right: discount will be the command line utility, libmarkdown the library itself and libmarkdown-devel will contain the headers. However, you need to fix the following: 1. Explicit requirements between the packages. Since the command line utility depends on the libmarkdown library, you should add an explicit require on the base package for libmarkdown. (Following the syntax here: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package) 2. In addition, if a user wants to develop software using libmarkdown, they will need libmarkdown to use the development files, so add a requirement for libmarkdown to the devel subpackage too. 3. Non-versioned shared libraries (libmarkdown.so) must be packaged in the development subpackage (http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages). (You should also remove the noarch parameter from -devel.) - You should select files in the %files section more verbosely: for example: 1. For the binary file, just do %{_bindir}/markdown 2. For the manual files, do something like %{_mandir}/manx/*.x* (where x is the number) 3. For the library files, you can select the versioned files with libmarkdown.so.* and the non-versioned file with just libmarkdown.so. - Needless to say, the description and summary for libmarkdown should contain something. - If you don't plan on building this package for EPEL5, you can remove %clean. Otherwise, you need to add a BuildRoot tag and do rm -rf %{buildroot} in the beginning of %install too. (http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review