Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: seedit: SELinux Policy Editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594 ------- Additional Comments From ynakam@xxxxxxxxxxxxxx 2007-01-18 02:18 EST ------- (In reply to comment #2) Thank you for comment. > %{distro} can be remove, %{?dist} do the same thing. Removed %{distro}. >#policy,gui subpackages are build only when arch is "noarch" >--> why don't you set them to noarch in spec file ? I wanted to make noarch.rpm not i386.rpm for doc and gui subpackage, but it seems that such sub packages are usually build as i386.rpm in fedora. So I removed %if s related to noarch, it is more simple. >your source0 must be point to the full path to verify the tarball. Fixed. >you use cd and cd .. to enter and exit from an subfolder, you can use pushd to enter and popd to exit. Fixed. > your desktop-file-install command miss some option such as mode and -add-categories. Fixed, add "-add-categories". > there is a lot of macros which's not in the right place. I looked at macros section of package guide line, but I am not sure what you mean. Can you tell me one example? Other fixes: - Added forgotten BuildRequires for libselinux,libsepol. - Added %{?_smp_mflags} to make New SPEC and SRPM: * SPEC http://prdownloads.sourceforge.jp/selpe/23577/seedit.spec * SRPM http://prdownloads.sourceforge.jp/selpe/23577/seedit-2.1.0-0.8.beta6.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review