Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request:gmrun - A lightweight "Run program" window with TAB completion https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222523 ------- Additional Comments From pertusus@xxxxxxx 2007-01-17 16:36 EST ------- * A quick look at the spec file shows that Group: and URL: are remnants from cgdb. * it doesn't seems to use directly glib2, so maybe the BR for gtk2-devel is sufficient * in my opinion, you could remove the leading 'A' from summary, and 'for minimal WMs'. * Once again %{_datadir}/gmrun/gmrunrc is not to be marked with %config. * the %{_datadir}/gmrun/ directory is unowned. * the default config file should be tuned a bit for fedora and apropriate dependencies should be added. In fact I think that it could be easier to rewrite the config file from scratch and add the upstream one in %doc In my opinion, the best integration would be achieved by calling xdg-open on every URL and on any file, whatever its extension is. Currently it is not possible to specify a default handler for url or files. Maybe upstream could be convinced to add that possibility to the config? In the mean time, I think that every entry in the config file should be handled with xdg-open. For URL_*, could be like: URL_http = xdg-open %u URL_mailto = xdg-open %u URL_man = xdg-open %u URL_info = xdg-open %u URL_pd = xdg-open %u URL_file = xdg-open %u URL_readme = xdg-open %u I removed URL_sh, I don't think it is that clever to handle such URI. Maybe some %u should in fact be %s, please adjust. And for EXT:*: EXT:txt,cc,cpp,h,java,html,htm,epl,tex,latex,js,css,xml,xsl,am,doc,rtf,ps,pdf = xdg-open %s The terminal should better be xterm in my opinion given the target of gmrun. * There is a missing BuildRequires on popt. (Hopefully on popt-devel once it is split). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review