Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-09-18 12:11:30 EDT --- A first brief look: > License: LGPLv2 File 'COPYING' and the source file headers explicitly mention "any later version", so: License: LGPLv2+ > BuildRoot: %{_tmppath}/%{name}-%{version}-build https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > Requires: liburcu >= 0.6.2 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %package -n libust-devel > ... > Requires: liburcu-devel > Requires: libust = %{version}-%{release} > Requires: libustinstr-malloc = %{version}-%{release} > Requires: libustfork = %{version}-%{release} > Requires: libustconsumer = %{version}-%{release} > Requires: libustctl = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %configure --disable-silent-rules --disable-dependency-tracking > ... > make CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags} Since %configure already passes on the CFLAGS (see 'rpm --eval %configure'), is the extra CFLAGS definition when running Make necessary? > %clean > rm -rf %buildroot https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > %post -n ust > /sbin/ldconfig > /usr/sbin/install-info /usr/share/doc/ust.info.gz > %preun -n ust > /usr/sbin/install-info --delete /usr/share/doc/ust.info.gz https://fedoraproject.org/wiki/Packaging:Guidelines#Scriptlets > %{_libdir}/libust.a https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries > %{_datadir}/info/ust.info.gz There also is %{_infodir} which is set by %configure, too. > %files Sometimes you use -n to explicitly specify the full package name (e.g. %post -n ust), here you don't. Then you also omit the -n for the base package's %post, %preun and %postun scriptlet sections for consistency. > https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Files COPYING, README and TODO could be included. It seems the test suite currently cannot be run. If it could be run during the build process, it would make sense to create a %check section for it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review