Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: IceWM - Lightweight Window Manager. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521 ------- Additional Comments From pertusus@xxxxxxx 2007-01-17 14:59 EST ------- Issues ====== * You should remove %config from default config files. Indeed %config is for files to be modified by the user. It is not the case for the files in %_datadir/icewm which hold the defaults and therefore should not be modified. You, as a packager are the one who can modify the files. Users can make system-wide changes in %{_sysconfdir}/icewm/ files, and each user makes his changes in ~/.icewm/ * with icewm-xdg-menu.py in /usr/bin, rpm creates files used for optimization of python. I don't know if it is problematic or right. rpmlint complains, but it may be ignorable. W: icewm non-executable-in-bin /usr/bin/icewm-xdg-menu.pyo 0644 W: icewm non-executable-in-bin /usr/bin/icewm-xdg-menu.pyc 0644 * /usr/bin/icewm-menu-gnome2 should in my opinion be in a subpackage, to avoid bringing in gnome dependencies to the main icewm package. * icewm.desktop should be 0644, so the install line should be install -p -m 644 %{SOURCE4} %{buildroot}%{_datadir}/xsessions/ * missing Requires: xterm * did you check the trademark issues with redhat-web-browser artwork? * License seems to be LGPL, from what I can see in COPYING, and on the sourceforge site. Many files lack a license notice, they only have a copyright. No license means a restrictive license (no right to modify or redistribute). Given that all the files which have a notice mention the LGPL, I guess there is no real issue. According to the FSF, the authors may not be completely sure that they can defend their license in a court unless they have the notice that appears at the end of the LGPL. Maybe you could report that upstream. Some files don't have a copyright notice. Usually it means that they are in the public domain (which is not an issue). Comments ======== * in my opinion the glob for the man page is better like %{_mandir}/man1/icewm.1* to get man pages even without compression * %find_lang %{name} seems to be enough, I guess the default is %{name}.lang for the file name. * you should consistently use %{__install} or install * you can use -b for patches to help those who like gendiff, so for example one would have %patch0 -p1 -b .configure and so on * in general it is not useful to repeat the package name in the summary, all the tools get the package name from the package name. Not a big deal. * I don't think that ' for the X Windows System' is really useful since it doesn't add any useful information. I would have choosed something like Summary: Light Window Manager -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review