Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542045 Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #27 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2011-09-17 13:13:09 EDT --- (In reply to comment #24) > > 5) php-htmlpurifier-htmlpurifier.noarch: W: no-documentation > > As your doc sub-package independent and does not require main package, at least > > LICENSE (and may be CREDITS) should be duplicated: > > Fixed > > http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > > > > Consider also require main package and move these docs to main package instead > > of sub-package: > > CREDITS, FOCUS, LICENSE, NEWS, README, TODO, VERSION, WHATSNEW > > Done You doc sub-package still don't require (its ok) base package. Guidelines (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing) say about duplicate only LICENSE file in this case, not all others marked as %doc! I think there may be (at you choose) also CREDITS. All other should be placed in doc subpackage only. Please fix it. In other things it is in good shape. Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review