Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - GTK frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326 ------- Additional Comments From martin.sourada@xxxxxxxxx 2007-01-17 13:43 EST ------- (In reply to comment #9) > I am still seeing a couple of spots I don't feel comfortable about: > > 1. The BR: gettext-devel seems superfluous to me. > AFAIS, "BR: gettext" should suffice. Oh, I think you are right. I don't remember, why I put there the gettext-devel BR... Fixed. > 2. The mozplugin has depencency problems wrt. the %{libdir}/mozilla/plugins > directory > > It must either > * own %{libdir}/mozilla/plugins > * Require a package providing %{libdir}/mozilla/plugins > * "Requires: %{libdir}/mozilla/plugins" > > AFAICT, their is no policy on handling mozilla-plugins, yet, so the most simple > work-around would be to "Requires: firefox". > Well, I didn't realize that. I looked at the totem package (which has also mozplugin subpackage) and noticed that it is also not handled there, so I did not think it necessary. However, I followed your advice and added Requires: firefox. Thanks for the tip. :-) New SPEC: http://feannatar.hostuju.cz/fedora/files/FC6/SPECS/gxine.spec New SRPM: http://feannatar.hostuju.cz/fedora/files/FC6/SRPMS/gxine-0.5.10-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review