Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: postgresql-dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199682 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2007-01-17 12:04 EST ------- Hi, (In reply to comment #9) > Well, as this package came up for discussion, I checked > this package. > > * As commented in fedora-extras-list, please remove > test/oracle (I confirmed that you did it). Yes, done in 0.2. > * Why does this package have "perl => 5.8.5, postgresql-devel >= 8.0" > for BuildRequires? > From your spec file, all rpmbuild has to do is just "install" > or "cp", so no other packages than mimimal buildroot environment > are needed That's my bad -- Removed that in 0.3. > * Files/directories entry > --------------------------------------- > %files > %defattr(-,root,root,-) > %doc copyright.txt IMPLEMENTATION.txt README.txt TODO.txt ROADMAP.txt > %{_datadir}/%{name}/ > > %files test > %defattr(-,root,root,-) > %doc README.txt > %{_datadir}/%{name}/test/csv > %{_datadir}/%{name}/test/mysql > %{_datadir}/%{name}/test/postgresql > ------------------------------------------------ > Well, this is wrong...... > > Writing as > ------------------------------------------------ > %{_datadir}/%{name}/ > ------------------------------------------------ > is interpretted as the directory %{_datadir}/%{name}/ and > all files/directories under %{_datadir}/%{name}/. > So, for example, all test files are also included in > main package, too. > > Please fix the file/directory entry so that there are > no duplicate entries. Fixed in new version. > And... why is README.txt installed in both packages? Yeah, ok. Removed. Thanks for the review. I'll submit the new spec and SRPM shortly. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review