Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736069 --- Comment #4 from Andy Grimm <agrimm@xxxxxxxxx> 2011-09-13 14:56:51 EDT --- (In reply to comment #1) > I'll do the shortened version because the spec is really small and clean. > Licensing is OK (ASL 2.0) rpmlint is completely clean. Basically everything is > A-OK. I just have 2 suggestions: > > 1. You can put the url directly into Source0. It would be a problem if there > were more pom.xml files, but that's not the case so... The reason I did not do this is that when you install the SRPM into your personal "rpmbuild" environment, you end up with a file called "pom.xml" in SOURCES ... and when I'm packaging lots of maven-based packages concurrently, this doesn't work out well. I suppose that if I switch to using git/fedpkg for all of my development, this is no longer an issue. > 2. It's usually better to be specific i.e. have %{_mavendepmapfragdir}/%{name} > instead of * (same for the pom line) This makes sense, though it would be good to see it in the guidelines if we prefer not to have people using globs. > These two non-issues are really small and basically up to you if you want to > handle them. Package is APPROVED. I'll remove common-poms apache-parent once > this package is in... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review