Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736051 --- Comment #2 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2011-09-13 08:03:50 EDT --- Review: <snip> Requires: ruby(abi) = %{rubyabi} .... Requires: ruby </snip> * Is this necessary? * Is the %prep section necessary? I can't see any tests running there. In %prep you copy all gem files with gem install in one place and in %install you move them to another. Why not use gem install in %install section? * Remove the 'echo %{SOURCE0}' * Is the rubygem(shoulda) really needed as a Runtime dependency? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review