Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737511 --- Comment #3 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2011-09-13 03:16:45 EDT --- (In reply to comment #2) > * Test suite execution > - I would suggest to replace the %check section with following content which > should provide similar results: > > pushd .%{geminstdir} > testrb -Itest test/lib/generators/haml/*_test.rb > popd > - Done > * Provides differs from upstream > - Is there any reason why you require rubygem(rails) instead of the gem set > which is used by upstream? Requires should be kept minimal as possible. > The test suite passes if rubygem(rails) dependency is replaced by: > > BuildRequires: rubygem(actionmailer) > BuildRequires: rubygem(activerecord) > > Are these gems really hard requirement? It seems that they are optional. > Please investigate. > - Yes, the tests pass without rubygem(rails) and with these two included, but you also need to include BR: rubygem(railties) > * Keep the test files > - If the test suite is part of the gem, please keep the tests in -doc > subpackage. > - The Gemfile should be also kept in -doc subpackage, as it is intended to be > used by the test suite - Done SPEC: http://bkabrda.fedorapeople.org/haml-rails/rubygem-haml-rails.spec SRPM: http://bkabrda.fedorapeople.org/haml-rails/rubygem-haml-rails-0.3.4-2.fc15.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3347553 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review