Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aqbanking - A library for online banking functions and financial data import/export https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222522 ------- Additional Comments From dakingun@xxxxxxxxx 2007-01-17 07:18 EST ------- You forgot to add the fixed doc directory to the file list. Adding it, and running rpmlint on the resulting packages produce; [deji@agape reviews]$ rpmlint aqbanking-2.1.0-13.src.rpm W: aqbanking unversioned-explicit-obsoletes aqhbci-devel - You forgot to version to this one. [deji@agape reviews]$ rpmlint aqbanking-2.1.0-13.x86_64.rpm E: aqbanking obsolete-not-provided aqhbci - aqbanking needs to also 'Provides: aqhbci' E: aqbanking zero-length /usr/share/aqbanking/bankinfo/us/bic.idx [deji@agape reviews]$ rpmlint aqbanking-devel-2.1.0-13.x86_64.rpm E: aqbanking-devel obsolete-not-provided aqhbci-devel - Also needs to provided for. E: aqbanking-devel zero-length usr/share/doc/aqbanking-devel-2.1.0/01-OVERVIEW - Can be left out of the doc list [deji@agape reviews]$ rpmlint qbanking-2.1.0-13.x86_64.rpm E: qbanking obsolete-not-provided aqhbci-qt-tools - I'm not sure you ever ship this, you can drop the obsolete or also provide it. W: qbanking no-documentation - I believe this and the rest like it can be ignored. [deji@agape reviews]$ rpmlint qbanking-devel-2.1.0-13.x86_64.rpm W: qbanking-devel no-documentation [deji@agape reviews]$ rpmlint kbanking-2.1.0-13.x86_64.rpm W: kbanking no-documentation [deji@agape reviews]$ rpmlint kbanking-devel-2.1.0-13.x86_64.rpm W: kbanking-devel no-documentation [deji@agape reviews]$ rpmlint python-aqbanking-2.1.0-13.x86_64.rpm W: python-aqbanking no-documentation [deji@agape reviews]$ rpmlint g2banking-devel-2.1.0-13.x86_64.rpm W: g2banking-devel no-documentation [deji@agape reviews]$ rpmlint g2banking-2.1.0-13.x86_64.rpm W: g2banking no-documentation And you really haven't fixed > * [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT > Useless check. Nowadays buildroot cannot be "/" anymore. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review