[Bug 705104] Review Request: freediams - Pharmaceutical Drugs Prescriptor

bugzilla@xxxxxxxxxx · Sat, 10 Sep 2011 00:37:23 -0400

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=705104

--- Comment #15 from Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> 2011-09-10 00:37:20 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
freediams.i686: E: devel-dependency freediams-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

freediams.i686: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
The value of this tag appears to be misspelled. Please double-check.

freediams.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

freediams.i686: W: spelling-error %description -l en_US informations ->
information, information's, in formations
The value of this tag appears to be misspelled. Please double-check.

freediams.i686: W: no-manual-page-for-binary freediams
Each executable in standard binary directories should have a man page.

freediams-data.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/Templates/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/MedinTux/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/DrugsBase/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/MainWindow/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/ExtensionSystem/.rcc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/Aggregation/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/Core/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/Printer/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/.ui
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/ExtensionSystem/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/TextEditor/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/Utils/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/TranslationUtils/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/SaveRestore/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/ListView/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/.ui
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/freediams-0.5.4/build/FreeDiams/Drugs/.moc
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libListView.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libMainWindow.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libTextEditor.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libCore.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libDrugs.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libDrugsBase.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libPrinter.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libTemplates.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: E: binary-or-shlib-defines-rpath
/usr/lib/freediams/libSaveRestore.so ['$ORIGIN', '$ORIGIN/..']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

freediams-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

freediams-docs.noarch: W: invalid-url URL: http://www.freemedforms.com/
<urlopen error timed out>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

5 packages and 0 specfiles checked; 10 errors, 41 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        No prebuilt external bits - OK, has sql database files
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK, has one error needs to be corrected
        API documentation - None, OK

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
Code and icons licensed as GPLv3. QT creator ui files are under LGPL. One of
the tests is under GPLv2. 
[+]MUST: The License field in the package spec file must match the actual
license.
GPLv3 
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Copying.txt is included
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum freediams-0.5.4-1.fc15.src/freediamsfullsources-0.5.4.tgz 
9f7c0123e74cc7acd3eb30e2b43d8d94 
freediams-0.5.4-1.fc15.src/freediamsfullsources-0.5.4.tgz

 md5sum ~/Downloads/freediamsfullsources-0.5.4.tgz 
9f7c0123e74cc7acd3eb30e2b43d8d94 ~/Downloads/freediamsfullsources-0.5.4.tgz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on i686
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.

[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
find_lang doesn't work properly on this package.

[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
None of the shared libraries go to the default lib path. So not needed.

[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list

[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.

[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides

[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.

[+]MUST: Permissions on files must be set properly.
Checked with ls -lR

[+]MUST: Each package must consistently use macros.

[+]MUST: The package must contain code, or permissible content.
Mysql databases, icons.

[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
Checked with ls -lR 

[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[+]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.

[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
This makes devel and base package interdependent.

[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[+]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
Already included.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the packages. Installs fine. Ran the application. Launches fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

Minor points
In description, I think it is information not informations.
One of the tests is under GPLv2 (modeltest-0.2). Will GPLv3 cover GPLv2 as
well? Otherwise we need to indicate GP:Lv2 in the license field.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review