[Bug 221065] Review Request: warzone2100 - Innovative 3D real-time strategy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: warzone2100 - Innovative 3D real-time strategy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221065





------- Additional Comments From faucamp@xxxxxxxxxx  2007-01-17 02:24 EST -------
(In reply to comment #15)
> Interpretation on content being under the GPL works for me. I'll sign off on it
> as ok.

Thanks, noted. :-)

(In reply to comment #16)
> I remove ExcludeArch-ppc, the building is correct. I do not know if it run (I
can not check it), but build is normal .

Have you tried starting it up via SSH with X11 forwarding? ("ssh -X") It would
be *dead* slow, but at least it should boot up.

(In reply to comment #17)
> It is the job of a package maintainer to modify sources as appropriate and to
> feed the changes upstream. The "important reason to flag -m32" is just that the
> code is broken and the authors do not consider fixing it a priority. Fedora has
> different standards, and you should take the lead on fixing it for 64-bit
operation.

I agree with this. However, having played around with the code a bit, it is
clear that a 64-bit port of this application will take some serious maintenance,
mostly due to its (legacy) Windows-centric memory handling (lots of ugly DWORDs
etc). Currently it compiles and starts up, but segfaults after the initial
loading screen.

Fixing this is a slightly big(ish) and time-consuming endeavour, one which would
benefit greatly from the assistance of a bigger Fedora audience; therefore my
current recommendation is to exclude x86_64 for now, add it to "devel", and file
a bug report against warzone2100 detailing the 32-bit-windows-to-64-bit-linux
pointer issues (see Bug #158646 for an example). The point is, in the long run,
the 64-bit issue will *have* to be fixed, but it might be solved quicker if the
package is accepted for devel/i386 and ppc, and a specific bug report is filed
against it.

I will let this suggestion simmer for a day or so before taking action, so if
someone does not agree with this idea, please speak up.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]