[Bug 689056] Review Request: lmd - Linux Malware Detecter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=689056

--- Comment #6 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2011-09-08 20:10:37 EDT ---
> [A]: Fix it ;)
> [B]: Fix indentation issue

Fixed. 

> [C]: Fix FSF address take a look at http://www.fsf.org/about/contact/ and eg
> /usr/share/doc/kdeaccessibility-4.6.5/COPYING

I emailed the author. 

> [D] Please coud you contact to upstream to determine what kind of license
> should be applied to the entire package as Martin Gieseking  suggested? If
> upstream doesn't answer so let license be GPLv2 + GPLv2+

I emailed the author. 

> [E]: The comment in the specfile:

I've updated the comment.

> maldetect put my innocent fstab under qurantine!!!
> 
> I've tested with a lot of other innocent files and did it the same.
> 
> Please tell me if we should let come in this package in Fedora... Did I miss
> something?

I think I may have introduced a bug when it was upgraded to 1.4.0. Try scanning
again using the new RPM. You generally don't want to tell it to quarantine
results unless you're sure all the stuff it has found is valid. 

It may still come up with false positives, it is meant for scanning web sites
to find things like remote shells, irc bots, spamming scripts, etc. It is not
meant to be an antivirus program like Windows has, that will scan all files on
your computer.

If you'd like a better test of its abilities, google for terms like 'r57 shell'
or 'c99 shell' and try scanning those files.

I contacted the author this afternoon to see if he can clarify the licensing.
I'll give it a week or two before contacting him again. In the mean time,
here's and updated SPEC and SRPM:

Spec: http://mmckinst.fedorapeople.org/packages/maldetect/maldetect.spec
SRPM:
http://mmckinst.fedorapeople.org/packages/maldetect/maldetect-1.4.0-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]