Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736582 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2011-09-08 11:39:15 EDT --- Packaging looks fine, APPROVED * TODO Review [100%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [X] Source files match upstream - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [X] rpmlint [2/2] - [X] on src.rpm $ rpmlint ./ghc-primitive-0.3.1-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ./ghc-primitive-0.3.1-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] on x86_64.rpm $ rpmlint ./ghc-primitive-*.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [X] Build [3/3] - [X] Koji results - [X] BRs complete - [X] Directory ownership - [X] Spec inspection [7/7] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]]) - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential - [X] Development [2/2] - [X] Headers in -devel - [X] -devel, -static requires main -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review