Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731003 --- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2011-09-08 05:56:24 EDT --- Hi Pavel, Thanks for the review. I've made the changes you requested: Spec URL: http://salimma.fedorapeople.org/specs/funpl/lua-moonscript.spec SRPM URL: http://salimma.fedorapeople.org/specs/funpl/lua-moonscript-0.1.0-2.fc16.src.rpm - git checkout instructions added - git archive command's two lines properly joined with \ - tabs -> spaces - cp, install etc. no longer using macros (I normally don't use them, myself, but I based this spec on another Lua package that does) - added runtime requirements on the build dependencies The one change I didn't make is the dependency on lua-inotify: it's not used at build time, and at runtime it is conditionally used if available (if you want to watch a directory and automatically recompile changed source files). Since Fedora does not recommend using RPM's "Recommend" tag, I'll probably turn this into a runtime requirement once all the packages are reviewed, but there's probably no point making the packages harder to test right now, as it does not cause any breakage. Let me know if there's anything else that need changing. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review