Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736062 Karsten Hopp <karsten@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(karsten@xxxxxxxxx | |m) | --- Comment #2 from Karsten Hopp <karsten@xxxxxxxxxx> 2011-09-07 08:15:50 EDT --- Updated spec file and srpm/rpm are now available at http://people.redhat.com/karsten/SPECS/ppc64-diag.spec http://people.redhat.com/karsten/SRPMS/ppc64-diag-2.4.2-2.fc16.src.rpm http://people.redhat.com/karsten/RPMS/ppc64-diag-2.4.2-2.fc16.ppc64.rpm - servicelog is the name of a package, we can't change that easily to service-log. But I've changed the description to 'service log' - I'd like to keep the pointer to the config file in the description as long as the man pages are missing that describe where the daemon can be configured. - replaced systemd path with %{_unitdir} - added dist tag - license is EPL, http://sourceforge.net/projects/linux-diag/ is a page for several other packages, too. Those have these other licenses. - the tarball somehow got deleted from sourceforge, I've requested that it gets uploaded again in https://bugzilla.redhat.com/show_bug.cgi?id=731419#c6 - added Type=forking to systemd service file - added smp flags - package now owns %{_datadir}/ppc64-diag - all references for /ppc64-diag/ subdirectories got replaced by %{name} - fixed usage of %_libexecdir and %_sbindir - changed file requirements to package requirements - removed chkconfig dependency, that was for the sysv-initscript - perl dependency gets added automatically: # rpm -qp --requires ppc64-diag-2.4.2-2.fc16.ppc64.rpm| grep perl /usr/bin/perl perl(Getopt::Long) The permissions after a make install are messed up, that's why each file has a %attr: ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/e1000e 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/e1000e ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/with_regex/cxgb3 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/with_regex/cxgb3 ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/with_regex/gpfs 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/with_regex/gpfs ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/ppc64_diag_mkrsrc 0744L ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/with_regex/e1000e 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/with_regex/e1000e ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/cxgb3 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/cxgb3 ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/ppc64_diag_servagent 0744L ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/exceptions 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/exceptions ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/ppc64_diag_notify 0744L ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/gpfs 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/gpfs ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/ppc64_diag_setup 0744L ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/message_catalog/reporters 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/message_catalog/reporters ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/servevent_parse.pl 0744L ppc64-diag.ppc64: E: script-without-shebang /usr/share/ppc64-diag/servevent_parse.pl ppc64-diag.ppc64: E: non-standard-executable-perm /usr/share/ppc64-diag/ppc64_diag_migrate 0744L -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review