Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: postgresql-dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199682 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-16 11:13 EST ------- Well, as this package came up for discussion, I checked this package. * As commented in fedora-extras-list, please remove test/oracle (I confirmed that you did it). * Why does this package have "perl => 5.8.5, postgresql-devel >= 8.0" for BuildRequires? From your spec file, all rpmbuild has to do is just "install" or "cp", so no other packages than mimimal buildroot environment are needed * Files/directories entry --------------------------------------- %files %defattr(-,root,root,-) %doc copyright.txt IMPLEMENTATION.txt README.txt TODO.txt ROADMAP.txt %{_datadir}/%{name}/ %files test %defattr(-,root,root,-) %doc README.txt %{_datadir}/%{name}/test/csv %{_datadir}/%{name}/test/mysql %{_datadir}/%{name}/test/postgresql ------------------------------------------------ Well, this is wrong...... Writing as ------------------------------------------------ %{_datadir}/%{name}/ ------------------------------------------------ is interpretted as the directory %{_datadir}/%{name}/ and all files/directories under %{_datadir}/%{name}/. So, for example, all test files are also included in main package, too. Please fix the file/directory entry so that there are no duplicate entries. And... why is README.txt installed in both packages? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review