Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=735225 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx --- Comment #1 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-09-03 12:37:07 EDT --- == Review == The usual notes apply: * BuildRoot is unnecessary except on EL5 or older. If you're not building for EPEL, consider dropping it. * rm -rf $RPM_BUILD_ROOT at the beginning of %install is unnecessary except on EL5 or older. If you're not building for EPEL, consider dropping it. * %clean rm -rf $RPM_BUILD_ROOT is the default, except on EL5 or older. If you're not building for EPEL, consider dropping it. * %defattr(-,root,root,-) is the default for %files sections, except on EL5 or older. If you're not building for EPEL, consider dropping it. In addition, check-rpaths says: ERROR 0001: file '/usr/libexec/axis2c/tools/md5/md5' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/libexec/axis2c/tools/tcpmon/tcpmon' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/bin/axis2_http_server' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/bin/axis2_tcp_server' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_tcp_receiver.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_http_common.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_axiom.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_parser.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_http_sender.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_engine.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/axis2c/modules/logging/libaxis2_mod_log.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/axis2c/modules/addressing/libaxis2_mod_addr.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_http_receiver.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libguththila.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libaxis2_tcp_sender.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/libneethi.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/httpd/modules/libmod_axis2.so.0.6.0' contains a standard rpath '/usr/lib64' in [/usr/lib64] I tried --disable-rpath, but it didn't work. You must address this with one of the other methods: https://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath == RPMLINT == axis2c.x86_64: W: shared-lib-calls-exit /usr/lib64/libaxutil.so.0.6.0 exit@GLIBC_2.2.5 axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxutil.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguththila.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_axiom.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/httpd/modules/libmod_axis2.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_http_common.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/axis2c/modules/logging/libaxis2_mod_log.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_engine.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_http_sender.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_http_receiver.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_tcp_receiver.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libneethi.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_parser.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_xpath.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libaxis2_tcp_sender.so axis2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/axis2c/modules/addressing/libaxis2_mod_addr.so axis2c.x86_64: W: dangling-symlink /usr/lib64/axis2c/include /usr/include axis2c.x86_64: W: dangling-symlink /usr/lib64/axis2c/lib /usr/lib64 axis2c.x86_64: W: no-manual-page-for-binary axis2_http_server axis2c.x86_64: W: no-manual-page-for-binary axis2_tcp_server axis2c-devel.x86_64: W: no-documentation axis2c-devel.x86_64: W: non-conffile-in-etc /etc/rpm/macros.axis2c axis2c-doc.noarch: W: no-documentation All safe to ignore. axis2c.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/axis2c-1.6.0/INSTALL axis2c.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/axis2c-1.6.0/NEWS axis2c.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/axis2c-1.6.0/ChangeLog Please fix these. axis2c.x86_64: E: non-executable-script /usr/libexec/axis2c/tools/wsdl2c/WSDL2C.sh 0644L /bin/sh This should be set +x. axis2c.x86_64: W: log-files-without-logrotate /var/log/axis2c You should enable logrotate support here. Create a logrotate config as $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/%{name}, and be sure to add Requires: logrotate. man logrotate will give you the config syntax. axis2c-doc.noarch: E: non-executable-script /usr/share/axis2c/docs/download.cgi 0644L /bin/sh Does this really belong in the -doc package? axis2c-doc.noarch: W: devel-file-in-non-devel-package /usr/share/axis2c/docs/docs/hello/service/hello_svc.c axis2c-doc.noarch: W: devel-file-in-non-devel-package /usr/share/axis2c/docs/docs/hello/client/hello.c Safe to ignore. axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_streaming.c axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_streaming.h axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_internals.h axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_internals.c axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath.c axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_internals_parser.c axis2c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/axis2c-src-1.6.0/axiom/src/xpath/xpath_functions.c Please fix these (chmod -x on the source files in %prep should do the trick). Resolve these items in a new SRPM and I'll finish the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review