Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734275 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hobbes1069@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-09-02 12:09:53 EDT --- I'll go aheand and take this review. I've done some test builds but haven't installed and run them yet. I did make a (minor?) change to the icon handling. Since the upstream package provides more than one size of icon it seemed a shame not to include it. The guidelines are quite sparse in this area so don't consider this authoritative, but it seems that /usr/share/pixmaps is better if you only have one icon file because it doesn't have any "sized" sub-directories. Because we have two icon files available, it seems more appropriate to move them to /usr/share/icons. The code below is what I changed/added to your spec file. # Move icons to a better location mkdir -p %{buildroot}%{_datadir}/icons/hicolor/{48x48,64x64}/apps mv %{buildroot}%{_datadir}/pixmaps/%{name}_48x48.png \ %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png mv %{buildroot}%{_datadir}/pixmaps/%{name}_64x64.png \ %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/%{name}.png rm -rf %{buildroot}%{_datadir}/pixmaps As I mentioned I haven't installed the package yet but I have verified it does include the icons in the rpm so there's no reason it shouldn't work. Hoepfully I'll have some time this weekend to do the full guideline review. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review