Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514105 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(aldreygalindo@gma | |il.com) --- Comment #19 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2011-09-02 10:59:54 EDT --- courier-imap.src: E: description-line-too-long C This package contains the standalone Courier IMAP server, which is used to provide IMAP access courier-imap.src: E: description-line-too-long C to local mailboxes. Courier-IMAP is provided here as a separate package that can be used with courier-imap.src: W: non-standard-group System/Servers courier-imap.src: W: invalid-license GPLv3 with openssl exception courier-imap.src: W: invalid-license see COPYING courier-imap.src: W: strange-permission courier-imap.init 0755L SHOULD: drop or fix Group tag MUST: fix license, use something like this in .spec instead: # SSL exception, see COPYING License: GPLv3 with exceptions naming: ok SHOULD: drop unecessary BuildRequires: courier-authlib (which should already get pulled in from courier-authlib-devel) MUST: fix remaining generic namespace collisions, and use courier- prefix everywhere. examples include: /etc/pam.d/imap (since this currently Conflicts with cyrus-imap, grr, it should get fixed too ) SHOULD: other nice-to-have-fixed namespace issues include: %{_sysconfdir}/imapd-ssl.dist %{_sysconfdir}/imapd.cnf %{_sysconfdir}/imapd.dist %{_sysconfdir}/pop3d-ssl.dist %{_sysconfdir}/pop3d.cnf %{_sysconfdir}/pop3d.dist %{_datadir}/mkimapdcert %{_datadir}/mkpop3dcert %{_libexecdir}/imapd-ssl.rc %{_libexecdir}/imapd.rc %{_libexecdir}/pop3d-ssl.rc %{_libexecdir}/pop3d.rc (libexecdir could potentially just use %{_libexecdir}/courier/ subdir, for example) macros: NOT OK, MUST fix. See: http://fedoraproject.org/wiki/Packaging/Guidelines#Macros in particular, "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable." init: SHOULD: update to include systemd unit file, instead of sysv init http://fedoraproject.org/wiki/Packaging/Guidelines#Systemd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review