Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=735179 --- Comment #1 from Mark McLoughlin <markmc@xxxxxxxxxx> 2011-09-02 07:44:16 EDT --- Looks like a great start, here's what I came up with after a first look: To fix before approval: - invalid-url Source0, we should use one of the tarballs available here: http://keystone.openstack.org/tarballs/ Monty Taylor looks like the contact point to get the tarball generation job fixed: https://jenkins.openstack.org/view/Keystone/job/keystone-tarball/ - python_sitelib not needed any more: http://fedoraproject.org/wiki/Packaging:Python#Macros - BR python2-devel required: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - These deps all look to be just needed for the unit tests: BuildRequires: python-coverage python-webtest python-unittest2 python-pep8 we could try running the tests in %check, but otherwise drop those BR I think - Don't need to clean buildroot in %install any more: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - Need to deal with config file, log file, user/group creation, systemd units Suggestions: - http://keystone.openstack.org/ is a better URL? - It's a style preference, I guess, but I find having only a single package listed for each Requires: tag as more readable To bugzilla once the package has been added: - bugzilla for no-manual-page-for-binary - request LICENSE be included in the distribution - SELinux policy - uidgid reservation I've pushed my attempt to fix these up here: https://github.com/markmc/openstack-fedora-specs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review