Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fuse-smb - FUSE-Filesystem to fast and easy access remote resources via SMB https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222742 ------- Additional Comments From mr.ecik@xxxxxxxxx 2007-01-15 18:46 EST ------- REVIEW contains only a checklist, have a look at THINGS to do to find out what you need to do. REVIEW: * dist tag present, * package is licensed under GPL license, * license text included in %doc, * rpmlint is quiet, * sources match upstream (8b9268826b544ad124e016ced17d5310), * latest version is being packaged, !* BRs aren't proper, package fails to build in mock! !* provides and requires (some things needs to be fixed): fuse-smb-0.8.5-2.fc7.src.rpm =PROVIDES:= (none)=REQUIRES:= fuse-devel >= 2.3 samba-client fuse-smb-0.8.5-2.fc7.x86_64.rpm =PROVIDES:= fuse-smb = 0.8.5-2.fc7 =REQUIRES:= fuse >= 2.3 fuse-libs >= 2.3 libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.5)(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libsmbclient.so.0()(64bit) samba-common >= 3.0 * package isn't designed to be relocatable, * package doesn't create any directories and it doesn't own any directory it shouldn't, * %clean section is present and looks good * build root good * no duplicates in %files * all files have appropriate permissions * no scriptlets required * no need to any subpackages * no .la files * not a gui application THINGS to do: * add samba-client BR to get rid of mock errors. * you're using versioned dependecies unnecesarily. Also, some of them have to be removed completely. Have a look at fuse-smb-0.8.5-2.fc7.x86_64.rpm requires list. It requires libfuse.so.2 which is owned by fuse-libs and libsmbclient.so.0 owned by samba- common. It means you don't need samba-common and fuse-libs dependencies. Also, you can smoothly get rid of fuse dependency. You don't need versioned dependency for fuse-devel as well. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review